User Tasks: add discover-ec2 task type
#47062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
no-changelog
marcoandredinis
force-pushed
the
marco/discover_ec2_tasks
branch
from
4e32211 to
873c321
Compare
rosstimothy
approved these changes
Oct 2, 2024
marcoandredinis
force-pushed
the
marco/discover_ec2_tasks
branch
2 times, most recently
from
5e20588 to
497f0aa
Compare
tigrato
reviewed
Oct 4, 2024
| const ( | ||
| // TaskTypeDiscoverEC2 identifies a User Tasks that is created | ||
| // when an auto-enrollment of an EC2 instance fails. | ||
| // UserTasks that have this Task Type must include the DiscoverEC2 field. | ||
| TaskTypeDiscoverEC2 = "discover-ec2" | ||
| ) | ||
|
|
||
| // discoverEC2IssueTypes is a list of issue types that can occur when trying to auto enroll EC2 instances. | ||
| var discoverEC2IssueTypes = []string{ |
There was a problem hiding this comment.
should we move this closer to the types definition so it's easier to keep them aligned?
There was a problem hiding this comment.
I can change it 👍
The reasoning here is that I was trying to not add usertasks specific things to types.
I was also trying to add generic EC2 Auto Discover failures so that we can use them everywhere, even if not related to usertasks.
Well, thinking about this now, I think it's fine to not pursue one of the above goals.
I'll move the identifiers from types into usertasks.
This PR adds more business logic into the User Tasks, in particular into the `discover-ec2` task type. One of the key features of the DiscoverEC2 User Tasks is that we must have a single task per: - integration - region - account id - issue type This allows user to have a detailed view of the issues their are facing but still grouping EC2 instances. To do this, we had to move the region and account id up one level. Previously they were at the instance level, and it would require iterating over them to actually create the group (uniq key) we want. This also adds well known errors as issue types to ensure we validate them. A later PR will come where we actually start creating/updating DiscoverEC2 User Tasks from the DiscoveryService.
marcoandredinis
force-pushed
the
marco/discover_ec2_tasks
branch
from
497f0aa to
649c8be
Compare
tigrato
approved these changes
Oct 4, 2024
public-teleport-github-review-bot
bot
removed the request for review
from camscale
marcoandredinis
force-pushed
the
marco/discover_ec2_tasks
branch
from
649c8be to
43cbfc1
Compare
|
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Oct 4, 2024
* User Tasks: add `discover-ec2` task type This PR adds more business logic into the User Tasks, in particular into the `discover-ec2` task type. One of the key features of the DiscoverEC2 User Tasks is that we must have a single task per: - integration - region - account id - issue type This allows user to have a detailed view of the issues their are facing but still grouping EC2 instances. To do this, we had to move the region and account id up one level. Previously they were at the instance level, and it would require iterating over them to actually create the group (uniq key) we want. This also adds well known errors as issue types to ensure we validate them. A later PR will come where we actually start creating/updating DiscoverEC2 User Tasks from the DiscoveryService. * use strings.Compare * improve docs and fix typos
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* User Tasks: add `discover-ec2` task type This PR adds more business logic into the User Tasks, in particular into the `discover-ec2` task type. One of the key features of the DiscoverEC2 User Tasks is that we must have a single task per: - integration - region - account id - issue type This allows user to have a detailed view of the issues their are facing but still grouping EC2 instances. To do this, we had to move the region and account id up one level. Previously they were at the instance level, and it would require iterating over them to actually create the group (uniq key) we want. This also adds well known errors as issue types to ensure we validate them. A later PR will come where we actually start creating/updating DiscoverEC2 User Tasks from the DiscoveryService. * use strings.Compare * improve docs and fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more business logic into
discover-ec2User Task.One of the key features of the DiscoverEC2 User Tasks is that we must have a single task per:
This allows user to have a detailed view of the issues their are facing but still grouping EC2 instances.
To do this, we had to move the region and account id up one level. Previously they were at the instance level, and it would require iterating over them to actually create the group (uniq key) we want.
This also adds well known errors as issue types so that we can do validations on the tasks.
A later PR will come where we actually start creating/updating DiscoverEC2 User Tasks from the DiscoveryService.
Context: #41909